vendor: update github.com/in-toto/in-toto-golang v0.10.0#6533
Merged
tonistiigi merged 2 commits intomoby:masterfrom Feb 24, 2026
Merged
vendor: update github.com/in-toto/in-toto-golang v0.10.0#6533tonistiigi merged 2 commits intomoby:masterfrom
tonistiigi merged 2 commits intomoby:masterfrom
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
github-actions
bot
added
the
area/dependencies
crazy-max
commented
Feb 24, 2026
Comment on lines
+16
to
21
| // Deprecated: ProvenancePredicate exists for historical compatibility | ||
| // and should not be used. This implementation has been superseded by the | ||
| // Provenance struct generated from the Protobuf definition provided | ||
| // by the in-toto Attestation Framework. | ||
| // https://github.com/in-toto/attestation/tree/main/protos/in_toto_attestation/predicates/provenance/v1. | ||
| type ProvenancePredicate struct { |
Member
Author
There was a problem hiding this comment.
@tonistiigi Looks like they deprecated provenance v1 structs in favor of protos: in-toto/in-toto-golang#267
We could switch to https://github.com/in-toto/attestation that is proto first:
- https://github.com/in-toto/attestation/tree/main/go/v1
- https://github.com/in-toto/attestation/tree/main/go/predicates/provenance/v1
- https://github.com/in-toto/attestation/tree/main/go/predicates/provenance/v02
Would need some protojson marshal/unmarshal hop and convert the predicate proto to structpb.Struct to embed in the Statement afaik.
Or we could generate predicate structs from json schemas and drop github.com/in-toto/in-toto-golang for provenance?
WDYT?
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
tonistiigi
approved these changes
Feb 24, 2026
| // format is defined by builder.id; by default it is treated as opaque and | ||
| // case-sensitive. The value SHOULD be globally unique. | ||
| InvocationID string `json:"invocationID,omitempty"` | ||
| InvocationID string `json:"invocationId,omitempty"` |
Member
There was a problem hiding this comment.
Note to readers that this is a breaking change if your parser is case sensitive (json.Unmarshal is not). No way around it though as this is how it is in the spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.