Make node join event logging less noisy#1833
Merged
Merged
Conversation
Commit 9010390 added a number of debugging messages for node join/leave events. This patch checks if a node already was listed, and otherwise skips the logging to make the logs a bit less noisy. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
change-loglevel
branch
from
45634fa to
502890a
Compare
thaJeztah
changed the title
|
LGTM |
|
@thaJeztah this PR never really worked 😄 |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 9010390 added a number of debugging messages for node join/leave events.
This patch checks if a node already was listed, and otherwise skips the logging to make the logs a bit less noisy.
relates to #1775
addresses moby/moby#33962
ping @sanimej PTAL - we may want to have this in a 17.06.x patch release