Add test to confirm garbage collection#1957
Merged
Merged
Conversation
fcrisciani
force-pushed
the
netdb-gc-test
branch
from
b9d96ce to
6d8443c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1957 +/- ##
=========================================
Coverage ? 38.81%
=========================================
Files ? 137
Lines ? 27358
Branches ? 0
=========================================
Hits ? 10620
Misses ? 15441
Partials ? 1297
Continue to review full report at Codecov.
|
fcrisciani
force-pushed
the
netdb-gc-test
branch
from
6d8443c to
8751a73
Compare
fcrisciani
force-pushed
the
netdb-gc-test
branch
from
8751a73 to
540b97f
Compare
- Create a test to verify that a node that joins in an async way is not going to extend the life of a already deleted object Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
fcrisciani
force-pushed
the
netdb-gc-test
branch
from
540b97f to
c832d78
Compare
AntaresS
reviewed
Nov 1, 2017
| func TestNetworkDBGarbageCollection(t *testing.T) { | ||
| keysWriteDelete := 5 | ||
| config := DefaultConfig() | ||
| config.reapEntryInterval = 30 * time.Second |
There was a problem hiding this comment.
Just want to make sure, I saw in the networkdb.go it has reapEntryInterval = 30 * time.Minute. Are we reducing it to 30 seconds in order to save time in the test?
Author
There was a problem hiding this comment.
yep, this is only for test purposes and not to delay the unit test CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in an async way is not going to extend the life
of a already deleted object
Signed-off-by: Flavio Crisciani flavio.crisciani@docker.com