[17.12] Enable IPV6 config on Sandbox creation on live-restore#2059
Merged
Conversation
In sandbox creation we disable IPV6 config. But this causes problem in live-restore case where all IPV6 configs are wiped out on running container. Hence extra check has been added take care of this issue. Signed-off-by: selansen <elango.siva@docker.com> (cherry picked from commit 76bfcb0) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## bump_17.12 #2059 +/- ##
==============================================
- Coverage 40.18% 40.04% -0.15%
==============================================
Files 138 138
Lines 22135 22135
==============================================
- Hits 8895 8863 -32
- Misses 11935 11971 +36
+ Partials 1305 1301 -4
Continue to review full report at Codecov.
|
thaJeztah
changed the title
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #2043 for 17.12. I left out some unrelated commits from the PR
cherry picked from commit 76bfcb0, no conflicts
In sandbox creation we disable IPV6 config. But this causes problem in live-restore case
where all IPV6 configs are wiped out on running container. Hence extra check has been added
take care of this issue.