Use new plugin interfaces provided by plugin pkg#2199
Merged
Conversation
Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit aae1b0e) Signed-off-by: selansen <elango.siva@docker.com>
The use of `Client()` on v2 plugins is being deprecated so that we can be more flexible on the protocol used for plugins. This means checking specifically if the plugin implements the `Client() *plugins.Client` interface for V1 plugins, and for v2 plugins building a the client manually. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit 45824a2) Signed-off-by: selansen <elango.siva@docker.com>
Most of the libcontainer imports was just for a single test to marshal a simple type, meanwhile this caused all kinds of transient imports that are not really needed. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit a07a1ee) Signed-off-by: selansen <elango.siva@docker.com>
selansen
force-pushed
the
new_plugin_intf
branch
from
bf48585 to
d0b0dab
Compare
selansen
force-pushed
the
new_plugin_intf
branch
5 times, most recently
from
41b041c to
88323a8
Compare
selansen
changed the title
selansen
force-pushed
the
new_plugin_intf
branch
3 times, most recently
from
e7cc7dd to
3879845
Compare
Contributor
Author
|
Ping @fcrisciani @euanh |
euanh
approved these changes
Jun 27, 2018
fcrisciani
reviewed
Jun 27, 2018
| github.com/gordonklaus/ineffassign \ | ||
| github.com/client9/misspell/cmd/misspell \ | ||
| honnef.co/go/tools/cmd/gosimple | ||
| honnef.co/go/tools/cmd/gosimple |
fcrisciani
reviewed
Jun 27, 2018
| github.com/deckarep/golang-set ef32fa3046d9f249d399f98ebaf9be944430fd1d | ||
|
|
||
| github.com/docker/docker 162ba6016def672690ee4a1f3978368853a1e149 | ||
| github.com/docker/docker 162ba6016def672690ee4a1f3978368853a1e149 |
fcrisciani
reviewed
Jun 27, 2018
| return nil | ||
| } | ||
|
|
||
| func getPluginClient(p plugingetter.CompatPlugin) (*plugins.Client, error) { |
There was a problem hiding this comment.
isn't this function declared twice in the same remote package?
Contributor
Author
There was a problem hiding this comment.
Yes this has been declared twice but in different packages.
github.com/docker/libnetwork/IPAMS/remote
github.com/docker/libnetwork/drivers/remote
I thought its same package initially and wasted my time figuring out why it throws error when I remove one API definition :(
Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit 8856c1e) Signed-off-by: selansen <elango.siva@docker.com>
selansen
force-pushed
the
new_plugin_intf
branch
from
3879845 to
64aae14
Compare
Contributor
Author
|
Error seems to be due to cloud provider :)..not coz our PR !!! |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is follow up of #2174.
I fixed all test case failures.
Description:
The use of Client() on v2 plugins is being deprecated so that we can be more flexible on the protocol used for plugins.
This means checking specifically if the plugin implements the Client() *plugins.Client interface for V1 plugins, and for v2 plugins building a the client manually.