Small fix to ensure Assignment field indexes start at 1 - #1604
Merged
Conversation
…1, not 2 Signed-off-by: cyli <ying.li@docker.com>
Current coverage is 54.78% (diff: 100%)@@ master #1604 diff @@
==========================================
Files 84 84
Lines 14174 14174
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 7776 7765 -11
- Misses 5381 5385 +4
- Partials 1017 1024 +7
|
Contributor
|
LGTM |
Contributor
|
ping @docker/core-swarmkit-maintainers - let's merge this soon to minimize compatibility issues |
Collaborator
|
LGTM, though I think if this was just left as |
dperny
approved these changes
Oct 11, 2016
Contributor
Don't consider performance when making field id selections. Leaving at 2 is fine, but it always makes you wonder what happened to 1. Is he okay? |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the comment #1544 (comment).
cc @stevvooe