Skip to content

Disable rounding intrinsics#1026

Merged
adpaco merged 2 commits into
model-checking:mainfrom
adpaco:disable-rounding
Apr 8, 2022
Merged

Disable rounding intrinsics#1026
adpaco merged 2 commits into
model-checking:mainfrom
adpaco:disable-rounding

Conversation

@adpaco

@adpaco adpaco commented Apr 8, 2022

Copy link
Copy Markdown
Contributor

Description of changes:

Disables rounding intrinsics which appear to be replaced by assert-false statements for some reason (debugging will come later). We could leave them "as is", but in my opinion we should control how they behave for now and only enable them when they are fixed and tested.

Resolved issues:

Part of #727

Call-outs:

Testing:

  • How is this change tested? Adds 6 negative tests.

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco adpaco requested a review from a team as a code owner April 8, 2022 16:17

@zhassan-aws zhassan-aws left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling them until they're fixed sounds like the right thing to me. Should we replace their implementations with:

codegen_unimplemented_intrinsic!(
                "https://github.com/model-checking/kani/issues/1025"

though?

@adpaco adpaco force-pushed the disable-rounding branch from f0861ac to 9a2a3fc Compare April 8, 2022 18:45
@adpaco

adpaco commented Apr 8, 2022

Copy link
Copy Markdown
Contributor Author

Should we replace their implementations with:

codegen_unimplemented_intrinsic!(
                "https://github.com/model-checking/kani/issues/1025"

though?

Yes, thanks! It's done.

@adpaco adpaco merged commit dca944a into model-checking:main Apr 8, 2022
tedinski pushed a commit to tedinski/rmc that referenced this pull request Apr 26, 2022
* Disable rounding intrinsics

* Use `codegen_unimplemented_intrinsic`
tedinski pushed a commit that referenced this pull request Apr 27, 2022
* Disable rounding intrinsics

* Use `codegen_unimplemented_intrinsic`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants