Skip to content

Remove implementation for the unreachable intrinsic #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adpaco merged 3 commits into from
Apr 25, 2022
Merged

Remove implementation for the unreachable intrinsic #1100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
823debc
Remove `unreachable` from intrinsics
adpaco Apr 23, 2022
99b08dd
Add test for uses of `unreachable`
adpaco Apr 23, 2022
626acfa
Merge branch 'main' into unreachable-audit
adpaco Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions kani-compiler/src/codegen_cprover_gotoc/codegen/intrinsic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,12 +607,6 @@ impl<'tcx> GotocCtx<'tcx> {
}
"unchecked_sub" => codegen_op_with_overflow_check!(sub_overflow),
"unlikely" => self.codegen_expr_to_place(p, fargs.remove(0)),
"unreachable" => self.codegen_assert(

@zhassan-aws zhassan-aws Apr 25, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since unreachable should be unreachable, I suggest making this more explicit:

"unreachable" => unreachable!("Expecting unreachable intrinsic to be handled using Terminator::Unreachable")

because just removing it gives the impression that it is not yet implemented (gets included in the _ bucket at the end of match statement).

@adpaco adpaco Apr 25, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will add this in a follow-up PR.

Expr::bool_false(),
PropertyClass::DefaultAssertion,
"unreachable",
loc,
),
"volatile_copy_memory" => unstable_codegen!(codegen_intrinsic_copy!(Memmove)),
"volatile_copy_nonoverlapping_memory" => {
unstable_codegen!(codegen_intrinsic_copy!(Memcpy))
Expand Down
2 changes: 2 additions & 0 deletions tests/expected/intrinsics/unreachable/expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
FAILURE\
"unreachable code"

@danielsn danielsn Apr 25, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline?

10 changes: 10 additions & 0 deletions tests/expected/intrinsics/unreachable/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0 OR MIT
#![feature(core_intrinsics)]

#[kani::proof]
fn main() {
unsafe {
std::intrinsics::unreachable();
}
}