Skip to content

Declare unreachable intrinsic as unreachable#1119

Merged
adpaco merged 1 commit into
model-checking:mainfrom
adpaco:unreachable-unreachable
Apr 27, 2022
Merged

Declare unreachable intrinsic as unreachable#1119
adpaco merged 1 commit into
model-checking:mainfrom
adpaco:unreachable-unreachable

Conversation

@adpaco

@adpaco adpaco commented Apr 27, 2022

Copy link
Copy Markdown
Contributor

Description of changes:

Includes the case for unreachable in the intrinsics match that is expected to be unreachable. This case was removed in #1100 (includes a test for unreachable), but as suggested by @zhassan-aws this way we avoid confusion.

Resolved issues:

Resolves #1115

Call-outs:

Testing:

  • How is this change tested? Existing regression.

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco adpaco requested a review from a team as a code owner April 27, 2022 19:18

@zhassan-aws zhassan-aws left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adpaco adpaco merged commit fbd5264 into model-checking:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Case for unreachable intrinsic is unreachable

2 participants