Build custom sysroot with --always-encode-mir on#1717
Merged
Conversation
zhassan-aws
approved these changes
Sep 26, 2022
zhassan-aws
left a comment
zhassan-aws
left a comment
Contributor
There was a problem hiding this comment.
The PR changes are quite big! Might help to break this up into multiple PRs (e.g. may want to have a first PR that updates the make-kani-release tool).
| name = "make-kani-release" | ||
| version = "0.1.0" | ||
| name = "build-kani" | ||
| version = "0.10.0" |
Contributor
Author
There was a problem hiding this comment.
Yeah, I need to update my branch.
The size of the bundle did increase quite a bit on my linux machine. It went from 24MB to 67MB. This is still pretty far from GitHub's max size of 2GB: https://docs.github.com/en/repositories/releasing-projects-on-github/about-releases#storage-and-bandwidth-quotas
celinval
force-pushed
the
issue-1605-sysbuild
branch
from
cd1c24c to
63410c2
Compare
Contributor
Author
I would really like to break this PR down, but I'm afraid the regression won't pass if I do. |
adpaco
approved these changes
Sep 27, 2022
celinval
added a commit
to celinval/kani-dev
that referenced
this pull request
Sep 29, 2022
After model-checking#1717 was merged, users need to run `cargo build-dev` to build Kani binaries and the sysroot.
This was referenced Sep 29, 2022
Closed
celinval
added a commit
that referenced
this pull request
Sep 29, 2022
After #1717 was merged, users need to run `cargo build-dev` to build Kani binaries and the sysroot.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change builds a custom sysroot for Kani. This new sysroot will contain a "lib/" folder with Kani libraries as well as the standard libraries compiled with
--always-encode-mir. This enable us to fully traverse the std MIR and fix the missing functions errors.Other changes to the build were described in the issue here: #1605 (comment)
Resolved issues:
Resolves #1605
Resolves #241
Related RFC:
Tracking issue #1588 .
Call-outs:
I'm still fixing all the workflows, but I could use some early feedback.
Testing:
How is this change tested? New tests
Is this a refactor change? Kinda
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.