Add support for the ARM64 Linux platform#2757
Merged
Merged
Conversation
jaisnan
approved these changes
Sep 12, 2023
jaisnan
left a comment
jaisnan
left a comment
Contributor
There was a problem hiding this comment.
LGTM! But I wonder if we should include documentation changes to the same PR?
zhassan-aws
approved these changes
Sep 12, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds support for the
aarch64-unknown-linux-gnuplatform (ARM64 Linux). It does not include installation nor CI workflows, only manually-tested support.The main complication came from the concrete playback feature (#2718), which returns characters instead of numbers for interpreted values in some cases. This PR includes a fix to convert them into their ASCII values.
Resolved issues:
Resolves #1367
Resolves #2718
Call-outs:
Testing:
How is this change tested? Manually, with existing tests on an ARM64 machine.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.