Delete obsolete stubs for Vec and related options#2770
Merged
Conversation
adpaco
approved these changes
Sep 15, 2023
celinval
approved these changes
Sep 15, 2023
celinval
left a comment
Contributor
There was a problem hiding this comment.
Thank you! Can you please document this as a major change to the release notes? I don't think we need to add them to breaking changes, since this was an unstable option.
Contributor
Author
Done |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The
Vecstubs have been obsolete for 2+ years, are not getting tested in our CI, and the related options (--use-absand--abs-type) don't work. The stubs code has bugs (e.g. the one pointed out in #2766). Since we're currently taking a different approach for stubbing (stubbing functions and methods as opposed to types), this PR removes all theVecstubs and related functionality.Resolved issues:
Resolves #697
Resolves #2766
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
Testing:
How is this change tested?
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.