Draft of initial RMC documentation#471
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Remove 'reasonable'. Maybe start with some motivation. Why do you want to invest time learning RMC?
Contributor
Author
There was a problem hiding this comment.
Did the first. I also added more context.
avanhatt
reviewed
Sep 7, 2021
Contributor
There was a problem hiding this comment.
Maybe add that cargo will handle most of the installation for these dependencies?
Contributor
There was a problem hiding this comment.
Recommend adding to .bashrc/.bash_profile?
zhassan-aws
reviewed
Sep 7, 2021
Contributor
There was a problem hiding this comment.
property tests -> property-based tests?
Contributor
There was a problem hiding this comment.
Is this command necessary (I don't recall running it in my initial setup). I just did that, and it's been running for over 30 minutes for me and seems to be cloning a lot of repositories:
Cloning into '/home/zyadh/rmc/firecracker'...
Cloning into '/home/zyadh/rmc/library/backtrace'...
Cloning into '/home/zyadh/rmc/library/stdarch'...
Cloning into '/home/zyadh/rmc/src/doc/book'...
Cloning into '/home/zyadh/rmc/src/doc/edition-guide'...
Cloning into '/home/zyadh/rmc/src/doc/embedded-book'...
Cloning into '/home/zyadh/rmc/src/doc/nomicon'...
Cloning into '/home/zyadh/rmc/src/doc/reference'...
Cloning into '/home/zyadh/rmc/src/doc/rust-by-example'...
Cloning into '/home/zyadh/rmc/src/doc/rustc-dev-guide'...
Cloning into '/home/zyadh/rmc/src/llvm-project'...
Contributor
Author
There was a problem hiding this comment.
I've assumed it was necessary, since our CI is doing it.
tedinski
force-pushed
the
initial-docs
branch
from
bf5469b to
d7909e5
Compare
tedinski
added a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Draft of initial RMC documentation * revisions in response to feedback
tedinski
added a commit
that referenced
this pull request
Apr 27, 2022
* Draft of initial RMC documentation * revisions in response to feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Some initial documentation for RMC.
Resolved issues:
N/A
Call-outs:
Nothing special.
Testing:
How is this change tested? -
Is this a refactor change? -
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.