Introduce the first section of the RMC tutorial#474
Merged
Conversation
zhassan-aws
reviewed
Sep 10, 2021
Contributor
There was a problem hiding this comment.
This function might confuse people. Should we include prelude.rs instead to "hide" some of the confusion?
Contributor
Author
There was a problem hiding this comment.
I sort of, kind of, hide it already, at least in that this code doesn't actually appear in the documentation.
But yes, we need to find a good way to address this. Right now it looked like there's no good way to include the prelude! The tests we have, at any rate, have to directly refer to it by relative path.
Fixing this is probably a major developer experience issue. My thought is: fix that, then revise this sample.
I create #477 to take this as a note.
tedinski
force-pushed
the
tutorial-1
branch
from
cad9b89 to
87da61a
Compare
tedinski
added a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Introduce the first section of the RMC tutorial * add license boilerplate, correct typos * fix formatting
tedinski
added a commit
that referenced
this pull request
Apr 27, 2022
* Introduce the first section of the RMC tutorial * add license boilerplate, correct typos * fix formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add the first section of the RMC tutorial.
Resolved issues:
Progress towards #254
Call-outs:
Testing:
How is this change tested? The new little crate can
cargo testandcargo rmcandrmc tests/final-form.rs. This currently isn't in CI. That will be deferred until later.Is this a refactor change? no
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.