Skip to content

Simplify pr workflow to require 2 approvals on all PR's#74

Merged
tautschnig merged 2 commits into
model-checking:mainfrom
jaisnan:fix-pr-flow
Aug 27, 2024
Merged

Simplify pr workflow to require 2 approvals on all PR's#74
tautschnig merged 2 commits into
model-checking:mainfrom
jaisnan:fix-pr-flow

Conversation

@jaisnan

@jaisnan jaisnan commented Aug 27, 2024

Copy link
Copy Markdown

Simplify pr workflow to require 2 approvals on all PR's

Call Outs

All PR's will need 2 approvals from the commitee for this check to pass.
A more intelligent approach is on the way, but till then all PR's will need 2 approvals.

This is done to prevent sneak attacks where someone gets approval for non-std related changes, and after approval, they make changes to the std files.

Testing

Failed check after just 1 approver :- https://github.com/jaisnan/rust-dev/actions/runs/10583003063
Successful check after 2nd approver :- https://github.com/jaisnan/rust-dev/actions/runs/10583018556

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@jaisnan jaisnan requested a review from a team as a code owner August 27, 2024 17:40

@carolynzech carolynzech left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could comment this out instead of deleting if you think you'll iterate on it later, but up to you.

@jaisnan

jaisnan commented Aug 27, 2024

Copy link
Copy Markdown
Author

You could comment this out instead of deleting if you think you'll iterate on it later, but up to you.

What do you mean by "this" in "comment this out"?
If youre talking about the closed PR, then I prefer to start afresh. I need a fresh testing ground for the checks.

@carolynzech

Copy link
Copy Markdown

You could comment this out instead of deleting if you think you'll iterate on it later, but up to you.

What do you mean by "this" in "comment this out"? If youre talking about the closed PR, then I prefer to start afresh. I need a fresh testing ground for the checks.
I meant comment out the sections of the files you deleted in this PR.

@jaisnan

jaisnan commented Aug 27, 2024

Copy link
Copy Markdown
Author

You could comment this out instead of deleting if you think you'll iterate on it later, but up to you.

What do you mean by "this" in "comment this out"? If youre talking about the closed PR, then I prefer to start afresh. I need a fresh testing ground for the checks.
I meant comment out the sections of the files you deleted in this PR.

Ah sorry. I think I prefer to delete, I can always refer to this PR in case I want to come back to these diffs, and I stashed these changes in my fork too. No reason to keep this branch full of redundant comments.

@tautschnig tautschnig merged commit c191318 into model-checking:main Aug 27, 2024
szlee118 pushed a commit to stogaru/verify-rust-std that referenced this pull request Oct 17, 2024
…ng#74)

Simplify pr workflow to require 2 approvals on all PR's

## Call Outs
All PR's will need 2 approvals from the commitee for this check to pass.
A more intelligent approach is on the way, but till then all PR's will
need 2 approvals.

This is done to prevent sneak attacks where someone gets approval for
non-std related changes, and after approval, they make changes to the
std files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants