Remove explicit SSE content encoding#1598
Open
DragonFSKY wants to merge 1 commit into
Open
Conversation
Signed-off-by: Dongliang Xie <dragonfsky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #1574.
SSE responses currently emit
Content-Encoding: identityeven though no content coding is applied. RFC 9110 section 8.4 definesContent-Encodingas the list of content codings that were applied to the representation and notes thatidentityis reserved forAccept-Encoding, so it SHOULD NOT be included inContent-Encoding.Since no SSE content coding is applied here, the response can omit the header while still preserving the existing SSE buffering controls.
Changes
Content-Encoding: identityassignment from SSE response initialization.Cache-Control,X-Accel-Buffering, andDisableBuffering()behavior.How Has This Been Tested?
dotnet test tests/ModelContextProtocol.AspNetCore.Tests/ModelContextProtocol.AspNetCore.Tests.csproj -f net10.0 --filter "FullyQualifiedName~EventSourceResponse_Includes_ExpectedHeaders"identity.dotnet test tests/ModelContextProtocol.AspNetCore.Tests/ModelContextProtocol.AspNetCore.Tests.csproj -f net10.0 --no-build --no-restoreBreaking Changes
None.
Types of changes
Checklist