-
Notifications
You must be signed in to change notification settings - Fork 751
Implement RFC 9207 issuer validation in ClientOAuthProvider #1605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mikekistler
wants to merge
9
commits into
main
Choose a base branch
from
sep-2468-iss-validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+580
−154
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0bb5fb7
Implement RFC 9207 issuer validation in ClientOAuthProvider
83f95f4
Skip RFC 8414 issuer validation in legacy 2025-03-26 backcompat path
cfadb00
Merge origin/main into sep-2468-iss-validation
5fa4edf
Merge branch 'main' into sep-2468-iss-validation
dc79995
Simplify OAuth authorization callback
halter73 82a9d74
Merge main into sep-2468-iss-validation and migrate step-up tests
ea8c1e0
Suppress ApiCompat baseline errors for removed AuthorizationRedirectD…
b735e0d
Address issuer validation review
halter73 83f78ad
Merge main and address OAuth review
halter73 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
src/ModelContextProtocol.Core/Authentication/AuthorizationCallbackContext.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| namespace ModelContextProtocol.Authentication; | ||
|
|
||
| /// <summary> | ||
| /// Provides the information needed to complete an OAuth authorization request. | ||
| /// </summary> | ||
| public sealed class AuthorizationCallbackContext | ||
| { | ||
| /// <summary> | ||
| /// Gets the authorization URI that the user needs to visit. | ||
| /// </summary> | ||
| public required Uri AuthorizationUri { get; init; } | ||
|
|
||
| /// <summary> | ||
| /// Gets the redirect URI where the authorization response will be sent. | ||
| /// </summary> | ||
| public required Uri RedirectUri { get; init; } | ||
| } |
28 changes: 0 additions & 28 deletions
28
src/ModelContextProtocol.Core/Authentication/AuthorizationRedirectDelegate.cs
This file was deleted.
Oops, something went wrong.
39 changes: 39 additions & 0 deletions
39
src/ModelContextProtocol.Core/Authentication/AuthorizationResult.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| namespace ModelContextProtocol.Authentication; | ||
|
|
||
| /// <summary> | ||
| /// Represents the result of an OAuth authorization redirect, containing the authorization code | ||
| /// and optionally the issuer identifier from the authorization response. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// <para> | ||
| /// The <see cref="Iss"/> property should be populated from the <c>iss</c> query parameter in the | ||
| /// redirect URI when present, as specified by | ||
| /// <see href="https://datatracker.ietf.org/doc/html/rfc9207">RFC 9207</see>. | ||
| /// This enables the SDK to validate that the authorization response originated from the expected | ||
| /// authorization server, mitigating mix-up attacks. | ||
| /// </para> | ||
| /// </remarks> | ||
| public sealed class AuthorizationResult | ||
| { | ||
| /// <summary> | ||
| /// Gets the authorization code returned by the authorization server. | ||
| /// </summary> | ||
| public string? Code { get; init; } | ||
|
|
||
| /// <summary> | ||
| /// Gets the issuer identifier returned in the authorization response per | ||
| /// <see href="https://datatracker.ietf.org/doc/html/rfc9207">RFC 9207</see>. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// <para> | ||
| /// This value should be extracted from the <c>iss</c> query parameter of the redirect URI. | ||
| /// When present, the SDK validates it against the expected authorization server issuer to | ||
| /// prevent mix-up attacks. | ||
| /// </para> | ||
| /// <para> | ||
| /// Implementations of <see cref="ClientOAuthOptions.AuthorizationCallbackHandler"/> should populate this | ||
| /// property whenever the <c>iss</c> parameter is present in the redirect URI callback. | ||
| /// </para> | ||
| /// </remarks> | ||
| public string? Iss { get; init; } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.