fix: Prevent unnecessary reconnection attempts in OAuth callback by removing connectMcpServer from dependency array#259
Closed
olaservo wants to merge 1 commit into
Conversation
9 tasks
max-stytch
approved these changes
Apr 3, 2025
Contributor
max-stytch
left a comment
There was a problem hiding this comment.
This solution will definitely work, but if the project is planning on eslint in the future we're going to need to revisit since the warning will still be valid. useEffect is just an annoying API to deal with.
That being said - the MCP Inspector is hard broken for anyone using OAuth right now (like me!), so I'm happy with any short term fix.
Member
|
@pulkitsharma07 verified that #253 fixes this. It is a more durable fix that doesn't mean having to ignore hooks rules. I think we can safely close this one. |
Member
Author
|
Closing since the other option was merged. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
See: #253 (comment)
Related to issue: #250
How Has This Been Tested?
nodeand arguments as path to ^^Breaking Changes
No
Types of changes
Checklist
Additional context
Longer term solution ideas mentioned here: #253 (comment)