fix(git): resolve Windows permission errors during test repository teardown#4220
Open
STiFLeR7 wants to merge 1 commit into
Open
fix(git): resolve Windows permission errors during test repository teardown#4220STiFLeR7 wants to merge 1 commit into
STiFLeR7 wants to merge 1 commit into
Conversation
1e43479 to
af53c65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a Windows-specific test teardown failure in
mcp-server-gittests due to:git.Repoinstance, causingshutil.rmtreeto raisePermissionError: [WinError 32].shutil.rmtreeto raisePermissionError: [WinError 5].Server Details
Motivation and Context
Developers attempting to run python tests for
mcp-server-giton Windows usinguv run pytestencounter permission errors during the teardown of thetest_repositoryfixture, which halts test suite completion. This fix resolves these issues, enabling local developer testing on Windows.How Has This Been Tested?
We verified the fix by running the test suite locally on a Windows host using:
All 41 tests passed successfully with no errors (previously, 35 out of 41 tests failed during the teardown phase with PermissionError).
Breaking Changes
Types of changes
Checklist
Additional context
onerrorpattern withshutil.rmtreeto clear the read-only attribute viaos.chmodprior to file removal.test_repo.close()to release all locks and file handles held by GitPython on the repo directory.