fix: preserve literal dollars in filesystem edits#4236
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
edit_filecurrently passesnewTextas the string replacement argument toString.prototype.replace. That makes literal$sequences behave like replacement patterns, so values such as$$100and$&are silently rewritten before the file is saved.This switches the exact-match path to the callback form of
replace, which preserves the existing first-match semantics while treating the replacement as literal text.Changes
modifiedContent.replace(normalizedOld, () => normalizedNew)for exact text edits.$$and$&in replacement text.To verify
npm exec -w src/filesystem -- vitest run __tests__/lib.test.ts --testNamePattern "dollar signs"npm exec -w src/filesystem -- vitest run __tests__/lib.test.tsnpm run build -w src/filesystemgit diff --check origin/main...HEADFixes #4157