-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(server): align ProtocolError re-throw with spec error classification #1769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
felixweinberger
wants to merge
11
commits into
main
Choose a base branch
from
fweinberger/protocol-error-rethrow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
49ab9e2
fix(server): align ProtocolError re-throw with spec error classification
felixweinberger e6b8a57
fix(server): use InvalidParams for task-required error and validate p…
felixweinberger 3f29f35
fix(server): only validate output for completed tasks in automatic po…
felixweinberger 66d6ea6
Merge branch 'main' into fweinberger/protocol-error-rethrow
felixweinberger 6268292
Merge branch 'main' into fweinberger/protocol-error-rethrow
felixweinberger 2502215
Merge remote-tracking branch 'origin/main' into fweinberger/protocol-…
felixweinberger 4633cb1
fix(server): convert mid-poll task errors and align config-error hand…
felixweinberger ad60a64
Merge branch 'main' into fweinberger/protocol-error-rethrow
felixweinberger 3ab699d
style: prettier
felixweinberger ffc96dd
Merge remote-tracking branch 'origin/main' into fweinberger/protocol-…
felixweinberger 54ef5ea
fix(server): address review feedback on ProtocolError re-throw alignment
felixweinberger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(server): convert mid-poll task errors and align config-error hand…
…ling Addresses review from @bhosmer-ant on #1769: - handleAutomaticTaskPolling: wrap getTask in try/catch and convert ProtocolError(InvalidParams) to InternalError when a task vanishes mid-poll. A task going missing during automatic polling is a server-side issue — the client didn't request a task. - handleAutomaticTaskPolling: change plain Error('No task store...') to ProtocolError(InternalError) for consistency with the analogous taskSupport config check at L177. - Update three tests to assert error codes (not just messages) using toMatchObject, matching the pattern at L1824. Follow-up (non-blocking): test coverage for the auto-polling output validation path added in 3f29f35.
- Loading branch information
commit 4633cb17f04dcaff49ce7201359831cde5429688
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.