Conversation
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
There was a problem hiding this comment.
LGTM — straightforward addition of publishConfig: { access: "public" } to all scoped packages to ensure they publish correctly to npm.
Extended reasoning...
Overview
This PR adds "publishConfig": { "access": "public" } to the package.json of six scoped packages: @modelcontextprotocol/client, @modelcontextprotocol/server, and the four middleware packages (express, fastify, hono, node). The change is identical across all six files and is purely additive — no logic, no tests, no runtime behavior is modified.
Security Risks
None. This is a package metadata change that only affects how npm publish behaves. It explicitly sets the npm publish access to public, which is the standard requirement for scoped packages (@scope/name) to be published to the public npm registry. Without this field, scoped packages default to restricted (private), which would cause publish failures unless the org has paid npm access configured. There is no security concern here.
Level of Scrutiny
Minimal scrutiny required. This is a mechanical, well-understood npm configuration fix. The pattern is identical in all six files, the field values are correct, and the fix directly matches the PR title. The recent commit history shows a sibling fix (#1836, #1833, #1829) around CI/release configuration, so this fits the same housekeeping pattern.
Other Factors
No bugs were found by the bug hunting system. No prior reviews exist on this PR. The changeset-bot note about no changeset is acceptable here since publishConfig is infrastructure metadata, not a user-facing API change.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context