Skip to content

fix(core): treat relatedRequestId 0 as present in debounce guard #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
utkarshsharma19 wants to merge 2 commits into from
+25 −1
Closed

fix(core): treat relatedRequestId 0 as present in debounce guard #2487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfa5528
fix(core): treat relatedRequestId 0 as present in debounce guard
utkarshsharma19 Jul 13, 2026
11511bc
Merge branch 'main' into fix/related-request-id-zero-debounce
utkarshsharma19 Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/core-internal/src/shared/protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1610,7 +1610,8 @@ export abstract class Protocol<ContextT extends BaseContext> {
const debouncedMethods = this._options?.debouncedNotificationMethods ?? [];
// A notification can only be debounced if it's in the list AND it's "simple"
// (i.e., has no parameters and no related request ID that could be lost).
const canDebounce = debouncedMethods.includes(notification.method) && !notification.params && !options?.relatedRequestId;
const hasRelatedRequestId = options?.relatedRequestId !== undefined;
const canDebounce = debouncedMethods.includes(notification.method) && !notification.params && !hasRelatedRequestId;

if (canDebounce) {
// If a notification of this type is already scheduled, do nothing.
Expand Down
23 changes: 23 additions & 0 deletions packages/core-internal/test/shared/protocol.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,6 +656,29 @@ describe('protocol tests', () => {
expect(sendSpy).toHaveBeenCalledWith(expect.any(Object), { relatedRequestId: 'req-2' });
});

it('should NOT debounce a notification that has relatedRequestId 0', async () => {
protocol = new TestProtocolImpl({ debouncedNotificationMethods: ['test/debounced_with_zero'] });
await protocol.connect(transport);

await protocol.notification({ method: 'test/debounced_with_zero' }, { relatedRequestId: 0 });
await protocol.notification({ method: 'test/debounced_with_zero' }, { relatedRequestId: 0 });

expect(sendSpy).toHaveBeenCalledTimes(2);
expect(sendSpy).toHaveBeenNthCalledWith(1, expect.any(Object), { relatedRequestId: 0 });
expect(sendSpy).toHaveBeenNthCalledWith(2, expect.any(Object), { relatedRequestId: 0 });
});

it('should reject debounced-method notifications when transport send fails with relatedRequestId 0', async () => {
protocol = new TestProtocolImpl({ debouncedNotificationMethods: ['test/debounced_with_zero'] });
await protocol.connect(transport);

sendSpy.mockRejectedValueOnce(new Error('send failed'));

await expect(protocol.notification({ method: 'test/debounced_with_zero' }, { relatedRequestId: 0 })).rejects.toThrow(
'send failed'
);
});

it('should clear pending debounced notifications on connection close', async () => {
// ARRANGE
protocol = new TestProtocolImpl({ debouncedNotificationMethods: ['test/debounced'] });
Expand Down
Loading