Skip to content

Result handling for FMI 3#309

Merged
modelonrobinandersson merged 11 commits intomasterfrom
dev-ra-7076
May 13, 2025
Merged

Result handling for FMI 3#309
modelonrobinandersson merged 11 commits intomasterfrom
dev-ra-7076

Conversation

@modelonrobinandersson
Copy link
Copy Markdown
Contributor

@modelonrobinandersson modelonrobinandersson commented May 5, 2025

No description provided.

@modelonrobinandersson modelonrobinandersson self-assigned this May 5, 2025
Comment thread tests/test_fmi3_sim.py
@modelonrobinandersson modelonrobinandersson changed the title Draft: Result handling for FMI 3 Result handling for FMI 3 May 6, 2025
@modelonrobinandersson modelonrobinandersson changed the base branch from dev-ra-7075 to master May 6, 2025 12:39
Comment thread src/pyfmi/fmi_util.pyx Outdated
Comment thread src/pyfmi/fmi_util.pyx Outdated
Comment thread src/pyfmi/fmi_util.pyx Outdated
Comment thread tests/test_fmi3.py Outdated
Comment thread tests/test_fmi3.py Outdated
Comment thread tests/test_fmi3_sim.py Outdated
Comment thread tests/test_fmi3_sim.py Outdated
Comment thread tests/test_fmi3_sim.py Outdated
Comment thread src/common/io.py Outdated
Comment thread src/common/io.py Outdated
Comment thread src/pyfmi/fmi_util.pxd Outdated
Comment thread src/pyfmi/fmi_util.pyx
Comment thread src/pyfmi/fmi_util.pyx
Comment thread src/pyfmi/fmi_util.pyx Outdated
Comment thread src/pyfmi/fmil3_import.pxd Outdated
Comment thread tests/test_fmi3.py
Comment thread tests/test_fmi3_sim.py Outdated
Comment thread tests/test_fmi3_sim.py Outdated
Comment thread tests/test_fmi3_sim.py Outdated
Comment thread src/common/io.py Outdated
Comment thread src/common/io.py Outdated
Comment thread src/pyfmi/fmi_util.pxd Outdated
Comment thread src/pyfmi/fmi_util.pyx
Comment thread src/pyfmi/fmi_util.pyx Outdated
Comment thread src/pyfmi/fmi_util.pyx Outdated
Comment thread src/pyfmi/fmil3_import.pxd Outdated
Comment thread tests/test_fmi3_sim.py Outdated
Comment thread tests/test_fmi3_sim.py Outdated
Copy link
Copy Markdown
Collaborator

@PeterMeisrimelModelon PeterMeisrimelModelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments left!

Comment thread tests/test_fmi3_sim.py Outdated
Comment thread tests/test_fmi3_sim.py Outdated
Comment thread src/pyfmi/fmi_util.pyx Outdated
Comment thread src/pyfmi/fmi_util.pyx
Comment thread src/pyfmi/fmi_util.pxd Outdated
Copy link
Copy Markdown
Collaborator

@PeterMeisrimelModelon PeterMeisrimelModelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge; a rebase should fix the GitHub Action build issue.

@modelonrobinandersson modelonrobinandersson merged commit 312bed2 into master May 13, 2025
2 checks passed
@modelonrobinandersson modelonrobinandersson deleted the dev-ra-7076 branch May 13, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants