update(Mf6Splitter): added split_multi_model method#2352
Merged
Conversation
Contributor
jlarsen-usgs
commented
Nov 2, 2024
- split_multi_model method allows splitting of connected GWF-GWT models
- update exchange remapping for GWT support
* split_multi_model method allows splitting of connected GWF-GWT models * update exchange remapping for GWT support
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2352 +/- ##
=========================================
- Coverage 74.4% 74.3% -0.1%
=========================================
Files 292 292
Lines 59526 59617 +91
=========================================
+ Hits 44308 44325 +17
- Misses 15218 15292 +74
|
Contributor
|
Hey @jlarsen-usgs , I looked at the failing test and realized I was having similar issues. The storage package is created with: which the splitter can't process into something valid. Reducing it to: works as intended. |
Contributor
Author
|
Thanks for pointing this out. I was at a loss yesterday afternoon as to what the difference was, because it runs fine on windows. I'll look into this some more; I should be able to put together a fix for mapping those records to the split models. |
mjr-deltares
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.