Skip to content

chore: cleanup - #1

Merged
modukon merged 1 commit into
modukon:modukonfrom
deuchainn:modukon
Feb 3, 2024
Merged

chore: cleanup#1
modukon merged 1 commit into
modukon:modukonfrom
deuchainn:modukon

Conversation

@deuchainn

Copy link
Copy Markdown

Rather than adding more comments to the PR here, i created PR on your PR what has been done is the following:

  1. Run prettier + eslint linter on the code
  2. Replacement of var with let and const
  3. Prefer const rather than let, whenever the value is immutable
  4. Use string literals e.g. One: ${one} two: ${two} rather than string concatenation.
  5. Spaces between functions, if it makes sense to group them could use block grouping with region folding like e.g. // #region group many editors supports this, or just group by adding some comments.

@modukon
modukon merged commit 057ccff into modukon:modukon Feb 3, 2024
@deuchainn
deuchainn deleted the modukon branch February 3, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants