Add mojo-stdlib-contributing and mojo-stdlib-review skills#3
Open
msaelices wants to merge 13 commits into
Open
Add mojo-stdlib-contributing and mojo-stdlib-review skills#3msaelices wants to merge 13 commits into
mojo-stdlib-contributing and mojo-stdlib-review skills#3msaelices wants to merge 13 commits into
Conversation
Add a skill capturing patterns and pitfalls for contributing to the Mojo standard library, distilled from 30+ reviewed PRs. Covers process, assertion semantics, optimization verification with compile_info, benchmarks, testing, SIMD safety, and Writable trait patterns. Signed-off-by: Manuel Saelices <msaelices@gmail.com>
Maintainer review cycles are expensive. The skill should instruct the agent to ask the human to review the diff, PR description, and benchmarks before converting from draft to ready for review. Signed-off-by: Manuel Saelices <msaelices@gmail.com>
- Use standard editorial comment template from other skills - Add opening paragraph consistent with mojo-syntax/gpu-fundamentals - Remove content duplicated from mojo-syntax (Writable basics, deprecated APIs, comptime vs @parameter, move semantics) - Remove general git/build commands already in CLAUDE.md - Consolidate compile_info section, cut niche bullets - Merge changelog into process section - Reorder: process, assertions, optimizations, design, benchmarks, testing, SIMD, writable - Reduce from 169 to 111 lines (34% smaller) Signed-off-by: Manuel Saelices <msaelices@gmail.com>
Signed-off-by: Manuel Saelices <msaelices@gmail.com>
3 tasks
Member
|
!sync |
msaelices
changed the title
mojo-stdlib-contributing skill
Adds an adversarial red-team review skill for Mojo stdlib PRs. The skill spawns one parallel agent per PR that: - Reads the full diff and extracts every verifiable claim across 14 categories (process, API design, trait conformance, docstrings, tests, iterators, benchmarks, optimizations, code reuse, memory/lifetime, asserts, style, removed-line side effects, renames). - Verifies each claim against the actual stdlib source and the rules in `mojo-stdlib-contributing`. - Either posts review comments on the PR (default) or writes findings to `.specs/stdlib-review-<PR>.md` for the author to fix before flipping a draft PR to ready-for-review. Distilled from 30+ reviewed PRs against `modular/modular`. Assisted-by: AI
Adds the README entry for the new skill alongside `mojo-stdlib-contributing`. Assisted-by: AI
Flips the default output mode so findings are written to `.specs/stdlib-review-<PR>.md` unless the caller opts into posting on the PR via "in post mode" / "post comments" / "post to PR". Local mode is the typical use case (self-review of one's own draft before flipping to ready-for-review); post mode now requires an explicit opt-in. Also reorders the emit blocks in the agent prompt template (local first), updates the README entry, and tweaks the follow-up options so the local-mode "Fix locally" choice is the default. Assisted-by: AI
…ncise Adds a row in section D so reviews flag verbose or redundant docstrings in the PR being reviewed, and updates the "Fix locally" follow-up so any docstrings or comments written during fix-up stay terse.
# Conflicts: # README.md
msaelices
changed the title
mojo-stdlib-contributing skillmojo-stdlib-contributing and mojo-stdlib-review skills
|
!sync |
Member
|
@msaelices could you clear out the lint issue in the mds |
Author
|
MD013 lint fix pushed: prose wrapped to <=80 cols. Code blocks and tables left untouched (incl. the embedded review prompt). Ready for |
Member
|
!sync |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add two complementary skills for working on the Mojo standard library, both distilled from 30+ reviewed PRs to
modular/modular.mojo-stdlib-contributingPatterns and pitfalls for contributing to the Mojo stdlib. Covers:
assert_mode="safe"table)compile_infoand benchmarksblack_box/keep, setup outside hot loop)Some[Writer],FormatStruct)mojo-stdlib-reviewAdversarial (red-team) review of one or more Mojo stdlib PRs. Spawns parallel agents that deep-read every changed file, extract factual claims, and verify each against the actual stdlib source and the rules in
mojo-stdlib-contributing. Findings are classified (Critical / Factual / Completeness / Inconsistency / Question / Minor) and written to a local findings file by default ("local mode") so the author can self-review before flipping a draft PR to ready. Pass"in post mode"to post review comments on the PR viagh pr reviewinstead.Also updates
README.mdto document both skills.Assisted-by: AI