fix(rspack): avoid falsy values in checkSingleton#3487
Merged
ScriptedAlchemy merged 5 commits intomodule-federation:mainfrom Apr 23, 2025
Merged
fix(rspack): avoid falsy values in checkSingleton#3487ScriptedAlchemy merged 5 commits intomodule-federation:mainfrom
checkSingleton#3487ScriptedAlchemy merged 5 commits intomodule-federation:mainfrom
Conversation
🦋 Changeset detectedLatest commit: ea48919 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
Author
|
@2heal1 can we get this merged? |
ScriptedAlchemy
approved these changes
Mar 11, 2025
douglaszaltron
approved these changes
Mar 14, 2025
Member
|
Yes sorry, had some CI failures, let me see if it works now then ill merge this weekend |
Member
Author
|
bumping this for visibility - anything stopping us from merging this? |
f323928
into
module-federation:main
13 of 14 checks passed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
added a check for falsy values inside
checkSingletoninpackages/rspack/src/ModuleFederationPlugin.ts.This is similar to other places in the codebase when looking for
ModuleFederationPlugininstances, this specific change was based on the logic frompackages/enhanced/src/lib/container/ContainerPlugin.tsRelated Issue
n/a
Types of changes
Checklist