Skip to content

feat: add zephyr options to CLI #3571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zackarychapple merged 8 commits into from
Mar 7, 2025
Merged

feat: add zephyr options to CLI #3571

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
01a5fa6
feat: add zephyr options to CLI
Nsttt Mar 5, 2025
1562b72
chore: move files to use ts
Nsttt Mar 5, 2025
0f63970
chore: remove nulls
Nsttt Mar 5, 2025
2f1852c
docs: format readmes
Nsttt Mar 5, 2025
ea85adc
Merge branch 'feat/create-module-federation' into feat/add-zephyr
Nsttt Mar 6, 2025
eaf8b39
feat: use zephyr cli inside other cli
Nsttt Mar 6, 2025
bb7f02a
chore: cleanup
Nsttt Mar 6, 2025
2c206e8
Merge branch 'feat/create-module-federation' into feat/add-zephyr
Nsttt Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: remove nulls
  • Loading branch information
@Nsttt
Nsttt committed Mar 5, 2025
commit 0f63970141e753123faaef59f40b040c848a0513
10 changes: 5 additions & 5 deletions packages/create-module-federation/src/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ type Argv = {

type ProjectType = 'lib' | 'app' | 'zephyr';
type RoleType = 'consumer' | 'provider';
type AppTemplateName = 'modern' | 'rsbuild';
type AppTemplateName = 'modern' | 'rsbuild' | 'zephyr';
type ZephyrTemplateName = 'webpack' | 'rspack' | 'vite';
type LibTemplateName = 'rslib';
type ProviderInfo = {
Expand Down Expand Up @@ -209,15 +209,15 @@ function getTemplateName(
}: {
projectType: ProjectType;
roleType: RoleType;
framework: AppTemplateName | null;
framework: AppTemplateName;
},
args: Argv,
) {
if (projectType === 'app') {
return getAppTemplateName(
{
roleType,
framework: framework as AppTemplateName,
framework,
},
args,
);
Expand Down Expand Up @@ -247,7 +247,7 @@ async function forgeTemplate({
templateParameters: Record<string, string>;
distFolder: string;
}) {
let framework: AppTemplateName | null = 'modern';
let framework: AppTemplateName = 'modern';
let roleType: RoleType = 'provider';

if (projectType === 'app') {
Expand All @@ -272,7 +272,7 @@ async function forgeTemplate({
}),
);
} else if (projectType === 'zephyr') {
framework = null;
framework = 'zephyr';

roleType = checkCancel<RoleType>(
await select({
Expand Down