Draft
Conversation
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
5 tasks
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@module-federation/devtools
@module-federation/cli
create-module-federation
@module-federation/data-prefetch
@module-federation/dts-plugin
@module-federation/enhanced
@module-federation/error-codes
@module-federation/esbuild
@module-federation/managers
@module-federation/manifest
@module-federation/metro
@module-federation/metro-plugin-rnc-cli
@module-federation/metro-plugin-rnef
@module-federation/modern-js
@module-federation/modern-js-v3
@module-federation/native-federation-tests
@module-federation/native-federation-typescript
@module-federation/nextjs-mf
@module-federation/node
@module-federation/retry-plugin
@module-federation/rsbuild-plugin
@module-federation/rspack
@module-federation/rspress-plugin
@module-federation/runtime
@module-federation/runtime-core
@module-federation/runtime-tools
@module-federation/sdk
@module-federation/storybook-addon
@module-federation/third-party-dts-extractor
@module-federation/treeshake-frontend
@module-federation/treeshake-server
@module-federation/typescript
@module-federation/utilities
@module-federation/webpack-bundler-runtime
@module-federation/bridge-react
@module-federation/bridge-react-webpack-plugin
@module-federation/bridge-shared
@module-federation/bridge-vue3
@module-federation/inject-external-runtime-core-plugin
commit: |
Contributor
Bundle Size Report2 package(s) changed, 39 unchanged.
Total dist: 6.38 MB (+5.8 kB (+0.1%)) |
Contributor
Android Release APK for all devicesNote: if the download link expires, please re-run the workflow to generate a new build. Generated at 2026-02-15T22:38:19.776Z UTC |
Contributor
iOS Release APP for simulatorsNote: if the download link expires, please re-run the workflow to generate a new build. Generated at 2026-02-15T22:41:03.386Z UTC |
jbroma
reviewed
Feb 16, 2026
|
|
||
| describe('createBabelTransformer', () => { | ||
| it('escapes Windows paths for require()', () => { | ||
| const tmpDirPath = fs.mkdtempSync(path.join(os.tmpdir(), 'mf-metro-')); |
packages/metro-core/project.json
Outdated
Comment on lines
+30
to
+37
| }, | ||
| "test": { | ||
| "executor": "@nx/jest:jest", | ||
| "outputs": ["{workspaceRoot}/coverage/packages/metro-core"], | ||
| "options": { | ||
| "jestConfig": "packages/metro-core/jest.config.ts", | ||
| "passWithNoTests": true | ||
| } |
Member
There was a problem hiding this comment.
needs aligning with main, uses vitest now
Keep metro-core on the vitest Nx executor and remove the stale jest target. Switch babel-transformer Windows path tests to memfs-backed file operations. Co-authored-by: Cursor <cursoragent@cursor.com>
…path-resolution-47f0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where Babel transformer paths were incorrectly handled on Windows due to invalid backslash escapes. This is resolved by:
require(...)without quotes for safe path replacement.metro-coreto validate Windows path escaping.Related Issue
No explicit issue provided, addresses a general "fix this" request related to Windows path handling.
Types of changes
Checklist