Upgrade Slim, phpdotenv, and PHPUnit#376
Open
radiantjade wants to merge 1 commit into
Open
Conversation
Slim 4 removes the old Slim container, request, response, and error handler APIs, so the app now uses PSR-7/PSR-11 primitives and a small local container while keeping the existing route names and Twig path_for helper stable. phpdotenv and PHPUnit were upgraded at the same time so dependency resolution and the functional tests run on the modern stack. Constraint: Issue modxorg#98 requests Slim, phpdotenv, and PHPUnit major upgrades with code changes for breaking APIs Constraint: Docker daemon was unavailable locally, so verification used Homebrew PHP 8.5 with sources:init-provisioned docs Rejected: Keep Slim 3 compatibility wrappers | would leave the requested Slim 4 migration incomplete Rejected: Migrate league/commonmark to 2.x in this PR | separate renderer API migration beyond the requested dependency set Confidence: medium Scope-risk: moderate Directive: Do not remove the path_for Twig compatibility function until templates are migrated to Slim 4 url_for naming Tested: composer validate --strict; composer test; php -l over src tests public Not-tested: Docker compose install/test path because the local Docker daemon was not running
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #98.
Verification
Notes