Completely Embedded Installer#5
Closed
DavidRieman wants to merge 9 commits into
Closed
Conversation
* Made an Uninstall which works similar to Install, with the improved error handling. Also makes way for silent uninstall mode, if wanted. * Updated Install/Uninstall to use a temporary directory to extract the driver from embedded resources. This allows for the installer itself to be easy to embed/use automatically in apps needing ScpBus.
…nd-handling path.
* Resolved conflict: ScpDriverInstaller/DriverInstaller.cs * Allowed VS to fix spaces to fix mixing.
…ackage. * Simplifies and abstracts "Use DIFx to install a driver" scenarios for reuse, via a simple 'using' syntax for DIFx. * Eliminates the need to directly manage multiple dependencies for bitness; the correct version of DIFxAPI is extracted and used at run-time. Also, other ScpDriverInterface cleanup and improvements: * Removed unused references. * Reduced minimum framework version needed to use ScpDriverInterface. * Fixed a casting warning. * Some improved error handling.
* Completes stand-alone single-file installer ScpDriverInstaller.exe!
* Fixes an issue where Win32Exception err code casting issues caused us to fail to identify already-uninstalled case.
…n, took latest EmbeddedDIFx minor update, and took Fody version updates. Lightly tested (mainly with ScpTester) but everything seems to still be in order.
Owner
|
I appreciate the work that you've put into this, but I'm going to close this as the installer was only really included for convenience, as an example of how to install the drivers. It isn't the main purpose of this repo, and was never intended to be fully-featured, or be used in production apps. You are welcome to continue maintaining your own version of it in a fork or separate repo. Also sorry for the extremely late comment on this, I know your original PR was from like 7 years ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the industry movement renaming master->main branches caused auto-deletion of my last PR (#4). Reopening from my
mainin case this repository gets some maintenance attention again at some point. (See linked PR for details.)