fix: detect iTerm2 hotkey window as focused on macOS#76
Merged
mohak34 merged 1 commit intoMay 14, 2026
Conversation
Use lsappinfo instead of System Events AppleScript for frontmost app detection. System Events fails to detect iTerm2 as frontmost when it is configured with "Exclude from Dock and Cmd-Tab Application Switcher" (hotkey popup window mode). lsappinfo correctly reports iTerm2 as the frontmost app in this case.
mmatviyiv
force-pushed
the
fix/iterm2-hotkey-focus-detection
branch
from
652bf0b to
127f8f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
suppressWhenFocusednot working with iTerm2 hotkey popup windows on macOS.Problem
When iTerm2 is configured with "Exclude from Dock and Cmd-Tab Application Switcher" (hotkey popup window mode),
System EventsAppleScript fails to detect iTerm2 as the frontmost application. This causes the plugin to show notifications even when the user is actively interacting with iTerm2.Solution
Use
lsappinfo(built-in macOS CLI) instead ofSystem EventsAppleScript for frontmost app detection.lsappinfocorrectly reports iTerm2 as frontmost in this mode.Changes
src/focus.ts:getMacOSFrontmostAppName()now useslsappinfoas primary method withSystem Eventsas fallback