Open
Conversation
Owner
|
Wow this is super neat! Will test it in the staging url and merge it if everything goes well 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewritten
onDetectedmethod. Fetching on every single detect is not needed since there will be false detections.Rewritten and moved conditional logic into
onDetected. Now instead ofattempts(which is not very useful since 4th attempt might be a false one) detected barcodes are saved in the component statedetected: { 33634646346:[numberOfDetections] }. Before fetching now a barcode has to be detected 3 times. Happens instantly from my experience.Removed status condition
if (status === 1)beforecalling
this.onProductFound(code). A person needs to be informed if a barcode is not in openfoodfacts database. Withif (status === 1)this sad fact is not reported and the app keeps scanning forever.Finally removed
onInfoFetchedsince with all above changes there is no need in this method.