feat: add recording indicator visibility and position settings#51
Merged
moinulmoin merged 3 commits intomoinulmoin:mainfrom Jan 29, 2026
Merged
Conversation
…ng options Replace boolean show_pill_indicator toggle with a dropdown that provides three modes: - Never: pill is always hidden - Always: pill is shown on startup and stays visible - When Recording: pill only appears during recording (default) Windows 11 fixes: - Move pill position above the taskbar to prevent overlay issues where the pill would lose focus when clicking the taskbar or system tray icon - Add subtle outline (ring-1 ring-white/30) to improve pill visibility Also fixes window management to properly handle orphaned/stale webview windows by closing them before creating new ones and ensuring mutex guards are dropped before async await points. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add a new dropdown setting to configure where the recording indicator appears on screen: top, center, or bottom. Position dropdown is hidden when indicator visibility is set to "never". Implementation details: - Add PillIndicatorPosition type and setting field - Recreate pill window when position changes for immediate visual feedback - Make settings updates truly optimistic to fix dropdown responsiveness - Add fallback in get_pill_window for reliable window access - Add unit tests for position calculation and mode migration logic - Add frontend tests for RecordingPill and GeneralSettings indicator options Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add comprehensive logging throughout the pill visibility flow to help diagnose issues with the recording indicator appearing/hiding: - Log pill_indicator_mode resolution (stored vs legacy vs default) - Log should_hide_pill decisions with caller location - Log RecordingConfig pill settings when loaded - Log start_recording pill visibility decisions - Log mode changes in save_settings - Log startup pill mode resolution Also makes resolve_pill_indicator_mode pub(crate) for reuse. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation Details
PillIndicatorModeandPillIndicatorPositiontypesshow_pill_indicatorboolean settingTest plan
🤖 Generated with Claude Code