Fix integration tests#85
Merged
dantran merged 6 commits intomojohaus:masterfrom Dec 9, 2018
Inform-Software:fix-it
Merged
Conversation
The old check disabled the subversion tests if the version was newer (or older) then Subversion 1.8
This omission subtly broken some integration tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are a collection of changes to make the integration tests more usable:
AssumeFinally, I removed the invoker tests. I think having two places with integration tests might confuse (or even discourage) new contributors to the project - If you think this is a mistake, I'll remove the last commit from this branch.