feat: add optional AI app history cleanup#83
Merged
Conversation
6 tasks
edufalcao
added a commit
to edufalcao/PureMac
that referenced
this pull request
May 18, 2026
…y guard Rebases PR momenbasel#76 onto upstream/main (post momenbasel#70 Arabic, momenbasel#75 FDA TCC, momenbasel#80 dashboard redesign, momenbasel#83 AI history). Adds pt-BR alongside the existing locales and brings every bundled locale (en/es/ja/ar/pt-BR/zh-Hans/ zh-Hant) to key parity, then enforces that parity in CI via a new XCTest case. UI changes - Localize the full user-facing surface across the redesigned views (DashboardView replacing SmartScanView; MainWindow's Overview/ Applications/Cleanup sidebar; CategoryDetailView's hero card; AppListView/AppFilesView/OrphanListView; the new OnboardingView flow; AppearancePill; SettingsView tabs). - Wrap dynamic strings with String(format: String(localized: ...)) so locale-specific number/format substitutions stay correct. - Add a Settings > General Language picker covering System Default plus every bundled language, with a relaunch prompt because AppleLanguages is consumed at app startup. Infrastructure - Extract AppLanguage + AppLanguagePreferences into Models/. AppLanguagePreferences.apply only touches AppleLanguages and preserves AppleLocale. - Wire AppState with injection points (performStartupTasks, locationsProvider, appFileScanner) so the scan-for-app-files path is exercised by a unit test without touching the real filesystem, and expose appFileScanLocationCount / currentAppFileSearchLocationCount so the in-progress scan UI shows the location count instead of the placeholder discovered-files count. Tests - LocalizationFilesTests: parses every PureMac/*.lproj/ Localizable.strings and fails if any locale drifts from en. - AppLanguagePreferencesTests: verify apply(.english) and apply(.system) modify only AppleLanguages. - AppStateTests: verifies scanForAppFiles publishes the location count while results are pending, then resolves to the sorted discovered files. Build - project.yml registers PureMacTests and a shared scheme so `xcodebuild test` works from a clean checkout. xcodeproj regenerated via xcodegen. Verification - plutil -lint OK for all 7 .strings files (227 keys each). - xcodebuild test -only-testing:PureMacTests: 4 tests, 0 failures. - xcodebuild build -configuration Debug: SUCCEEDED. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #20 that adds optional local history cleanup for known local AI apps in the AI Apps category.
Why
Ollama and LM Studio can store prompt or conversation history separately from logs and caches. That history can contain sensitive user content, so it should be visible for inspection but never cleaned automatically.
This keeps AI Apps cleanup useful while preserving explicit user consent for history removal.
Scope
Included optional history targets:
~/.ollama/historyfor Ollama CLI prompt history~/.lmstudio/conversationsfor LM Studio conversationsThese items are surfaced as optional entries and are unselected by default.
Still excluded from cleanup:
~/.ollama/models~/.lmstudio/modelsImplementation
Validation
xcodebuild -project PureMac.xcodeproj -scheme PureMac -configuration Debug -derivedDataPath build CODE_SIGNING_ALLOWED=NO buildNotes
Logger.sharedstill appear during build and predate this PR.