Skip to content

DOCSP-51915: Update SearchAfter example#659

Merged
norareidy merged 1 commit into
mongodb:masterfrom
norareidy:DOCSP-51915-searchafter-full-doc
Jul 24, 2025
Merged

DOCSP-51915: Update SearchAfter example#659
norareidy merged 1 commit into
mongodb:masterfrom
norareidy:DOCSP-51915-searchafter-full-doc

Conversation

@norareidy

@norareidy norareidy commented Jul 15, 2025

Copy link
Copy Markdown
Collaborator

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-51915

Removes the projection to return the full document, rather than just the ID, make and pagination token

Staging Links

Atlas Search

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?
  • Are the page titles greater than 20 characters long and SEO relevant?
  • Did you add redirects?

@netlify

netlify Bot commented Jul 15, 2025

Copy link
Copy Markdown

Deploy Preview for docs-csharp ready!

Name Link
🔨 Latest commit 4eba1aa
🔍 Latest deploy log https://app.netlify.com/projects/docs-csharp/deploys/6876698796a387000895073f
😎 Deploy Preview https://deploy-preview-659--docs-csharp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@docs-builder-bot

Copy link
Copy Markdown

🔄 Deploy Preview for docs-csharp processing

Item Details
🔨 Latest Commit a43f4193ba3f71610a1bcee74b27ecf821566744
😎 Deploy Preview https://deploy-preview-659--docs-csharp.netlify.app
🔍 Build Logs View Logs

@lindseymoore lindseymoore left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending tech review

@norareidy norareidy requested review from a team and ajcvickers and removed request for a team July 15, 2025 17:47
@@ -339,7 +339,6 @@ public static List<Guitar> SearchAfter()

var result = guitarsCollection.Aggregate()

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to tech reviewer: this isn't the exact change the user suggested (see ticket), but it seems to work fine to return the full document. let me know if there's something I'm missing.

@ajcvickers

Copy link
Copy Markdown

@BorisDog Can you take a look at this since I'm not 100% about this in the C# driver?

@norareidy norareidy requested a review from BorisDog July 22, 2025 16:19

@ajcvickers ajcvickers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to sign off on this. After downloading and going through the code it now seems clear the adding the projection to Guitar here is correct and was just missed, which is what the original poster said.

Sorry for being slow!

@norareidy norareidy merged commit 34937e6 into mongodb:master Jul 24, 2025
7 checks passed
@norareidy norareidy deleted the DOCSP-51915-searchafter-full-doc branch July 24, 2025 14:15
norareidy added a commit that referenced this pull request Jul 24, 2025
norareidy added a commit that referenced this pull request Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants