Skip to content

feat: fix security issue in main branch#49

Merged
shuangela merged 1 commit into
mainfrom
DOCSP-56258-fix-security-main
Dec 8, 2025
Merged

feat: fix security issue in main branch#49
shuangela merged 1 commit into
mainfrom
DOCSP-56258-fix-security-main

Conversation

@shuangela

@shuangela shuangela commented Dec 8, 2025

Copy link
Copy Markdown
Collaborator

Fix security issue in main branch by updating dependency
Tested server and client locally and ran python tests and everything is as expected/passing

Jira - https://jira.mongodb.org/browse/DOCSP-56258

@dacharyc dacharyc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, the correct workflow is to merge the version bump PR to development and then make a PR from development to main. That should result in effectively the same thing, but follows the development -> main workflow. But in this case, since the change is so small, I think it's safe to shortcut it, keeping in mind this isn't the optimal workflow for other types of PRs.

@shuangela shuangela merged commit b0372bb into main Dec 8, 2025
1 check passed
@shuangela

Copy link
Copy Markdown
Collaborator Author

In theory, the correct workflow is to merge the version bump PR to development and then make a PR from development to main. That should result in effectively the same thing, but follows the development -> main workflow. But in this case, since the change is so small, I think it's safe to shortcut it, keeping in mind this isn't the optimal workflow for other types of PRs.

This makes sense! I was unsure which way we wanted to do so I opted for making both PRs at the same time but I'll keep this in mind for the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants