This repository was archived by the owner on Mar 5, 2024. It is now read-only.
DOCSP-876 - Decouple tabs from template.py. Migrate tab templates fro…#157
Merged
Conversation
…m docs repo to docs-tools.
i80and
approved these changes
Sep 11, 2017
i80and
left a comment
i80and
left a comment
Contributor
There was a problem hiding this comment.
lgtm! It might be preferable to make BUILT_IN_PATH an interned string and use defined_in is not BUILT_IN_PATH, but that'll complicate our transition to Python 3.
So... lgtm :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…m docs repo to docs-tools.
MERGE WITH: mongodb/docs#2951