This repository was archived by the owner on Mar 5, 2024. It is now read-only.
DOCSP-1682 - Change default tab behavior to render inline. Added 'hid…#178
Merged
Merged
Conversation
Contributor
Author
|
MUST BE MERGED WITH: |
i80and
suggested changes
Feb 23, 2018
i80and
left a comment
i80and
left a comment
Contributor
There was a problem hiding this comment.
Largely lgtm! A type issue though
| this.type = null; | ||
| if (this.tabStrip !== null) { | ||
| this.type = this.tabStrip.getAttribute('data-tab-preference'); | ||
| if (this.tabStrips !== null) { |
Contributor
There was a problem hiding this comment.
this.tabStrips will never be null given the above switch to querySelectorAll.
This should read if (this.tabStrips.length > 0) {
|
|
||
| setup() { | ||
| if (!this.tabStrip) { return; } | ||
| if (!this.tabStrips) { return; } |
|
|
||
| update() { | ||
| if (!this.tabStrip) { return; } | ||
| if (!this.tabStrips) { return; } |
i80and
approved these changes
Feb 26, 2018
i80and
left a comment
i80and
left a comment
Contributor
There was a problem hiding this comment.
If you've tested this out, I don't see anything wrong 👍
…den: true' property to hide tab strips. Added 'tabs-top' directive to pull tab strip to the top of the page.
jdestefano-mongo
force-pushed
the
DOCSP-1682v2
branch
from
e4bd101 to
a03ef19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…den: true' property to hide tab strips. Added 'tabs-top' directive to pull tab strip to the top of the page.
This change is