DOCSP-39569 changed limited to unsupported for setParameter#6275
Merged
Conversation
kennethdyer
approved these changes
Jun 13, 2024
kennethdyer
left a comment
kennethdyer
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this work @sonderdonk-mdb. Left a small nonblocking suggestion for your consideration. LGTM.
| @@ -1,4 +1,4 @@ | |||
| .. note:: | |||
Contributor
There was a problem hiding this comment.
Nonblocking Suggestion:
This is not in the scope of your project, but if you apply a two space indent to the include directive used to call this RST file, it'll render as a child of the lists item instead of breaking the list into two separate lists.
Bonus: Since the robots work from simplified HTML, I suspect that'll help their comprehension.
Contributor
Author
There was a problem hiding this comment.
spoke to Kenneth over slack, ended up not implementing
sonderdonk-mdb
force-pushed
the
DOCSP-39569
branch
from
a528b83 to
27df9c4
Compare
sonderdonk-mdb
force-pushed
the
DOCSP-39569
branch
from
27df9c4 to
db3a335
Compare
Contributor
Author
|
Will Pierce gave external review and approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
changed "this command has limited support" to "this command is unsupported" for setParameter compatibility section
STAGING
https://preview-mongodbsonderdonkmdb.gatsbyjs.io/docs/DOCSP-39569/reference/command/setParameter/#compatibility
JIRA
https://jira.mongodb.org/browse/DOCSP-39569
BUILD LOG
https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=666affc2ebce19f3148c3a21
SELF-REVIEW CHECKLIST
See the taxonomy tagging instructions and this example PR
EXTERNAL REVIEW REQUIREMENTS
What's expected of an external reviewer?