feat(ipa): Disallow resetting to a default value for optional fields - #120
Merged
Conversation
yelizhenden-mdb
changed the title
yelizhenden-mdb
marked this pull request as ready for review
August 5, 2026 13:36
yelizhenden-mdb
requested review from
andmatei,
andreaangiolillo,
drinkbird,
lovisaberggren,
matt-condon,
saisundar and
wtrocki
August 5, 2026 13:36
manupedrozo
approved these changes
Aug 5, 2026
| - Any fields not included in the request body **must** be unset | ||
| - If the client explicitly provides `null` for an optional field in the request, | ||
| the server **should** unset the field or reset it to its default value | ||
| the server **should** unset the field |
Collaborator
There was a problem hiding this comment.
Q: What is preventing this one from being a must? boolean fields?
Collaborator
Author
There was a problem hiding this comment.
If it is a non-nullable field, it will not be possible to unset it but the server will return a validation error instead
Collaborator
There was a problem hiding this comment.
If it is a non-nullable field
Hmm, I would expect this rule to not apply in that case. What are IPA-compliant optional, non-nullable fields?
lovisaberggren
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assigning a server-side default in place of a client-omitted value is an anti-pattern. This PR removes every mention of resetting to a default.