NODE-1168 promoteBuffers + GridFS = TypeError: doc.data.length is not a function - #1555
Merged
Conversation
… a function When using the promoteBuffers connect option, `doc.data` is already a node.js Buffer. So trying to call `length()` like for `BSON.Binary` fails. Fixed simply by checking `Buffer.isBuffer(doc.data)` type.
Author
|
CI failure seems unrelated to me |
daprahamian
approved these changes
Nov 16, 2017
daprahamian
added a commit
that referenced
this pull request
Nov 16, 2017
This is a port of #1555 to 3.0.0 branch. When using the promoteBuffers connect option, `doc.data` is already a node.js Buffer. So trying to call `length()` like for `BSON.Binary` fails. Fixed simply by checking `Buffer.isBuffer(doc.data)` type.
daprahamian
added a commit
that referenced
this pull request
Nov 17, 2017
This is a port of #1555 to 3.0.0 branch. When using the promoteBuffers connect option, `doc.data` is already a node.js Buffer. So trying to call `length()` like for `BSON.Binary` fails. Fixed simply by checking `Buffer.isBuffer(doc.data)` type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUG: https://jira.mongodb.org/browse/NODE-1168
When using the promoteBuffers connect option,
doc.datais already a node.js Buffer.So trying to call
length()like forBSON.Binaryfails.Fixed simply by checking
Buffer.isBuffer(doc.data)type.Would love to get your review, and fix whatever is needed.
Thanks