[Port] Better error message for slash in hostname - #1584
Merged
Conversation
added 2 commits
November 29, 2017 11:08
mbroadst
approved these changes
Nov 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports #1559 from the
2.2branch to3.0.Notes:
2.2and3.0in the test set up so it's not a direct transfer there.&& r.path.indexOf('::') === -1to line203because without it both test URIs end up with the slash error because they each contain 3 items in their array after the split:I'm not quite sure why the tests passed without this in
2.2cc @mbroadst for thoughts 💭