fix(collection): fix error when calling remove with no args - #1657
Merged
Conversation
daprahamian
force-pushed
the
NODE-1287
branch
from
January 30, 2018 16:46
e8aae86 to
b85d0ef
Compare
mbroadst
reviewed
Jan 30, 2018
| @@ -1236,6 +1236,8 @@ Collection.prototype.remove = function(selector, options, callback) { | |||
| options.ignoreUndefined = this.s.options.ignoreUndefined; | |||
| } | |||
|
|
|||
Member
There was a problem hiding this comment.
I think we actually need a whole:
if (typeof options === 'function') (callback = options), (options = {});
options = options || {};
// Add ignoreUndefined....
Contributor
Author
There was a problem hiding this comment.
Updated to include that
Calling remove with no arguments resulted in an error b/c of the lack of options. Fixes NODE-1287
daprahamian
force-pushed
the
NODE-1287
branch
from
January 30, 2018 17:14
b85d0ef to
3158d80
Compare
mbroadst
approved these changes
Jan 30, 2018
jlord
approved these changes
Jan 30, 2018
This was referenced Mar 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling remove with no arguments resulted in an error b/c
of the lack of options.
Fixes NODE-1287
@mbroadst @jlord I'm wondering if we should instead fix this in
executeOperation?