fix(NODE-4591): only set loadBalanced on handshake when explicitly set#3386
Merged
fix(NODE-4591): only set loadBalanced on handshake when explicitly set#3386
Conversation
baileympearson
changed the title
dariakp
approved these changes
Aug 26, 2022
nbbeeken
approved these changes
Aug 26, 2022
durran
pushed a commit
that referenced
this pull request
Aug 30, 2022
durran
pushed a commit
that referenced
this pull request
Aug 31, 2022
baileympearson
added a commit
that referenced
this pull request
Aug 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
We only set
loadBalancedon the initial hello when it is explicitly provided and set to true.Is there new documentation needed for these changes?
No.
What is the motivation for this change?
Spec compliance.
Note that the load balancer tests still fail. https://jira.mongodb.org/browse/SERVER-69146 has been filed to potentially revert the server changes so that
apiStrict: truecan be used with load balanced mode. If it turns out the server change is intended behavior, then there will probably be a drivers ticket to skip these tests on load balanced topologies.Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>