Provide listed assembly in process for moduleview#366
Merged
Conversation
sgmunn
reviewed
Jun 22, 2022
sgmunn
reviewed
Jun 22, 2022
sgmunn
reviewed
Jun 22, 2022
sgmunn
reviewed
Jun 22, 2022
Member
|
Please set a proper title and description of the PR |
slluis
reviewed
Jun 22, 2022
slluis
reviewed
Jun 23, 2022
sgmunn
reviewed
Jun 23, 2022
Therzok
reviewed
Jun 23, 2022
sgmunn
reviewed
Jun 27, 2022
slluis
reviewed
Jun 28, 2022
slluis
reviewed
Jun 28, 2022
slluis
reviewed
Jun 28, 2022
slluis
reviewed
Jun 28, 2022
slluis
requested changes
Jun 28, 2022
Member
slluis
left a comment
slluis
left a comment
There was a problem hiding this comment.
Please add a proper title and a proper description to the pull request.
jonathan34c
changed the title
jonathan34c
changed the title
jonathan34c
force-pushed
the
dev/t-jochang/moduleview
branch
2 times, most recently
from
39edfed to
2d394c1
Compare
mrward
reviewed
Jul 8, 2022
mrward
reviewed
Jul 8, 2022
slluis
reviewed
Jul 8, 2022
slluis
reviewed
Jul 8, 2022
slluis
reviewed
Jul 8, 2022
sgmunn
reviewed
Jul 8, 2022
jonathan34c
force-pushed
the
dev/t-jochang/moduleview
branch
from
2586afa to
e4c8dcd
Compare
Therzok
reviewed
Jul 10, 2022
mrward
reviewed
Jul 13, 2022
mrward
reviewed
Jul 13, 2022
slluis
reviewed
Jul 18, 2022
jonathan34c
force-pushed
the
dev/t-jochang/moduleview
branch
3 times, most recently
from
9721a95 to
03cf64f
Compare
jonathan34c
force-pushed
the
dev/t-jochang/moduleview
branch
from
03cf64f to
b1dd19e
Compare
mrward
reviewed
Jul 19, 2022
slluis
reviewed
Jul 20, 2022
slluis
approved these changes
Jul 20, 2022
sgmunn
reviewed
Jul 21, 2022
| public class Assembly | ||
| { | ||
| /// <summary> | ||
| /// Represent the assembly loaded during the debugging session. This dataclass will be used in the modules pad view for display. |
Member
There was a problem hiding this comment.
This dataclass will be used in the modules pad view for display.
this isn't relevant here, since other projects that use this library will have no context of vsmac.
sgmunn
reviewed
Jul 21, 2022
sgmunn
reviewed
Jul 21, 2022
| /// <summary> | ||
| /// Represent the assembly loaded during the debugging session. This dataclass will be used in the modules pad view for display. | ||
| /// </summary> | ||
| /// <param name="name"></param> |
Member
There was a problem hiding this comment.
You can probably omit the "String" / "Boolean" etc from the documentation here and just keep it like
" Represents the name of the assembly"
sgmunn
approved these changes
Jul 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.