Skip to content

Remove accrue interest supplycollat#52

Merged
MerlinEgalite merged 3 commits into
devfrom
perf/remove-accrue-interest-supplycollat
Jul 6, 2023
Merged

Remove accrue interest supplycollat#52
MerlinEgalite merged 3 commits into
devfrom
perf/remove-accrue-interest-supplycollat

Conversation

@MerlinEgalite
Copy link
Copy Markdown
Contributor

It's not breaking tests so I think we're missing some tests (which is normal at this stage)

@MathisGD
Copy link
Copy Markdown
Contributor

MathisGD commented Jul 5, 2023

It's not breaking tests so I think we're missing some tests (which is normal at this stage)

but at the same time, this accrueInterests was literally useless (but yes we miss a lot of coverage)

@MathisGD MathisGD linked an issue Jul 5, 2023 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good catch ! As told here, I would prefer to have a little comment replacing the "call", to explain why we don't need to do it.

makcandrov
makcandrov previously approved these changes Jul 5, 2023
Comment thread src/Blue.sol
QGarchery
QGarchery previously approved these changes Jul 5, 2023
pakim249CAL
pakim249CAL previously approved these changes Jul 5, 2023
@MerlinEgalite MerlinEgalite dismissed stale reviews from pakim249CAL, QGarchery, and makcandrov via 9b9ed18 July 5, 2023 17:28
@MerlinEgalite MerlinEgalite merged commit 91e050d into dev Jul 6, 2023
@MerlinEgalite MerlinEgalite deleted the perf/remove-accrue-interest-supplycollat branch July 6, 2023 12:40
@MathisGD MathisGD mentioned this pull request Jul 6, 2023
Merged
ret2basic pushed a commit to ret2basic/morpho-blue-scaffold that referenced this pull request Feb 9, 2026
…interest-supplycollat

Remove accrue interest supplycollat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should we accrue interest on collateral adjustments?

6 participants