Fix unsafe command execution in V4L2 control#3143
Merged
Conversation
When using the camera_add/add motioneye web API, the camera device path for obtaining supported resolutions is passed via post request body. Adding single quotes to this input lifts the single-quotation in the final command string, allowing command substitution and hence remote command injection/execution. In this case, the final command is executed in shell context to allow piping and parsing the output with grep. Use shlex.quote to safely single-quote the input, and have embedded single-quotes escaped, to prevent any possible shell expansion, including variables and command substitutions. Thanks to @hyperlyz for reporting this security vulnerability: #3142 Signed-off-by: MichaIng <micha@dietpi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the
camera_add/addmotionEye web API, the camera device path for obtaining supported resolutions is passed via post request body. Adding single quotes to this input lifts the single-quotation in the final command string, allowing command substitution and hence remote command injection/execution. In this case, the final command is executed in shell context to allow piping and parsing the output with grep.Use
shlex.quote()to safely single-quote the input, and have embedded single-quotes escaped, to prevent any possible shell expansion, including variables and command substitutions.Thanks to @hyperlyz for reporting this security vulnerability: #3142